Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies so make vet will pass #801

Merged
merged 1 commit into from
Oct 19, 2022
Merged

update dependencies so make vet will pass #801

merged 1 commit into from
Oct 19, 2022

Conversation

acornett21
Copy link
Contributor

@acornett21 acornett21 commented Oct 18, 2022 •
edited
Loading

Signed-off-by: Adam D. Cornett adc@redhat.com

@openshift-ci openshift-ci bot requested a review from skattoju October 18, 2022 21:08
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
@coveralls
Copy link

coveralls commented Oct 18, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 84.5% when pulling 4591a4f on acornett21:update_dependencies into 9e7705a on redhat-openshift-ecosystem:main.

@dcibot
Copy link

dcibot commented Oct 19, 2022

@bcrochet bcrochet added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 19, 2022
@acornett21
update dependencies so make vet will pass
4591a4f 
Signed-off-by: Adam D. Cornett <adc@redhat.com>
@dcibot
Copy link

dcibot commented Oct 19, 2022

@acornett21
Copy link
Contributor Author

/retest

skattoju
skattoju approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@skattoju skattoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2022

@sebrandon1: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

komish
komish approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

bcrochet
bcrochet approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish, sebrandon1, skattoju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish,skattoju]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bcrochet bcrochet merged commit 01c414d into redhat-openshift-ecosystem:main Oct 19, 2022
@acornett21 acornett21 deleted the update_dependencies branch October 19, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet approved these changes

@komish komish komish approved these changes

@sebrandon1 sebrandon1 sebrandon1 approved these changes

@skattoju skattoju skattoju approved these changes

Assignees

@bcrochet bcrochet

@komish komish

@skattoju skattoju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@acornett21 @coveralls @dcibot @bcrochet @komish @sebrandon1 @skattoju