Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/onsi/gomega from 1.20.2 to 1.22.1 #803

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Bump github.com/onsi/gomega from 1.20.2 to 1.22.1 #803

merged 1 commit into from
Oct 20, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 19, 2022

Bumps github.com/onsi/gomega from 1.20.2 to 1.22.1.

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.22.1

1.22.1

Fixes

  • When passed a context and no explicit timeout, Eventually will only timeout when the context is cancelled [e5105cf]
  • Allow StopTrying() to be wrapped [bf3cba9]

Maintenance

  • bump to ginkgo v2.3.0 [c5d5c39]

v1.22.0

1.22.0

Features

Several improvements have been made to Eventually and Consistently in this and the most recent releases:

  • Eventually and Consistently can take a context.Context [65c01bc] This enables integration with Ginkgo 2.3.0's interruptible nodes and node timeouts.
  • Eventually and Consistently that are passed a SpecContext can provide reports when an interrupt occurs [0d063c9]
  • Eventually/Consistently will forward an attached context to functions that ask for one [e2091c5]
  • Eventually/Consistently supports passing arguments to functions via WithArguments() [a2dc7c3]
  • Eventually and Consistently can now be stopped early with StopTrying(message) and StopTrying(message).Now() [52976bb]

These improvements are all documented in Gomega's docs

v1.21.1

Features

  • Eventually and Consistently that are passed a SpecContext can provide reports when an interrupt occurs [0d063c9]

v1.21.0

1.21.0

Features

  • Eventually and Consistently can take a context.Context [65c01bc] This enables integration with Ginkgo 2.3.0's interruptible nodes and node timeouts.
  • Introduces Eventually.Within.ProbeEvery with tests and documentation (#591) [f633800]
  • New BeKeyOf matcher with documentation and unit tests (#590) [fb586b3]

Fixes

  • Cover the entire gmeasure suite with leak detection [8c54344]
  • Fix gmeasure leak [119d4ce]
  • Ignore new Ginkgo ProgressSignal goroutine in gleak [ba548e2]

Maintenance

  • Fixes crashes on newer Ruby 3 installations by upgrading github-pages gem dependency (#596) [12469a0]
Changelog

Sourced from github.com/onsi/gomega's changelog.

1.22.1

Fixes

  • When passed a context and no explicit timeout, Eventually will only timeout when the context is cancelled [e5105cf]
  • Allow StopTrying() to be wrapped [bf3cba9]

Maintenance

  • bump to ginkgo v2.3.0 [c5d5c39]

1.22.0

Features

Several improvements have been made to Eventually and Consistently in this and the most recent releases:

  • Eventually and Consistently can take a context.Context [65c01bc] This enables integration with Ginkgo 2.3.0's interruptible nodes and node timeouts.
  • Eventually and Consistently that are passed a SpecContext can provide reports when an interrupt occurs [0d063c9]
  • Eventually/Consistently will forward an attached context to functions that ask for one [e2091c5]
  • Eventually/Consistently supports passing arguments to functions via WithArguments() [a2dc7c3]
  • Eventually and Consistently can now be stopped early with StopTrying(message) and StopTrying(message).Now() [52976bb]

These improvements are all documented in Gomega's docs

Fixes

Maintenance

1.21.1

Features

  • Eventually and Consistently that are passed a SpecContext can provide reports when an interrupt occurs [0d063c9]

1.21.0

Features

  • Eventually and Consistently can take a context.Context [65c01bc] This enables integration with Ginkgo 2.3.0's interruptible nodes and node timeouts.
  • Introduces Eventually.Within.ProbeEvery with tests and documentation (#591) [f633800]
  • New BeKeyOf matcher with documentation and unit tests (#590) [fb586b3]

Fixes

  • Cover the entire gmeasure suite with leak detection [8c54344]
  • Fix gmeasure leak [119d4ce]
  • Ignore new Ginkgo ProgressSignal goroutine in gleak [ba548e2]

Maintenance

  • Fixes crashes on newer Ruby 3 installations by upgrading github-pages gem dependency (#596) [12469a0]
Commits
  • 40d0cc9 v1.22.1
  • e5105cf When passed a context and no explicit timeout, Eventually will only timeout w...
  • bf3cba9 Allow StopTrying() to be wrapped
  • c5d5c39 bump to ginkgo v2.3.0
  • 8916066 v1.22.0
  • aeab53a fix go vet issue
  • 52976bb Eventually an Consistently can now be stopped early with StopTrying(message) ...
  • a2dc7c3 Gomega supports passing arguments to functions via WithArguments()
  • e2091c5 Eventually/Consistently will forward an attached context to functions that as...
  • 2e34979 v1.21.1
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump github.com/onsi/gomega from 1.20.2 to 1.22.1
4f4eed4 
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.20.2 to 1.22.1.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.20.2...v1.22.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 19, 2022
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 19, 2022
@dcibot
Copy link

dcibot commented Oct 19, 2022

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2022

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.5% when pulling 4f4eed4 on dependabot/go_modules/github.com/onsi/gomega-1.22.1 into 01c414d on main.

sebrandon1
sebrandon1 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would merge the ginkgo PR first then let the bot rebase this.

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2022

@sebrandon1: changing LGTM is restricted to collaborators

In response to this:

I would merge the ginkgo PR first then let the bot rebase this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@acornett21
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 20, 2022
bcrochet
bcrochet approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, dependabot[bot], sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit cc22295 into main Oct 20, 2022
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/onsi/gomega-1.22.1 branch October 20, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet approved these changes

@sebrandon1 sebrandon1 sebrandon1 approved these changes

@acornett21 acornett21 acornett21 approved these changes

@komish komish Awaiting requested review from komish

Assignees

@bcrochet bcrochet

@acornett21 acornett21

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dcibot @coveralls @acornett21 @bcrochet @sebrandon1