move main.go to be within the cmd directory structure and push all subcommands down one layer

[komish]

This PR is in preparation for exposing code at the top layer of the directory structure to be library code. We have to move main.go into cmd so that the import path can be correct for library code, and also probably should anyway as it doesn't hurt anything.

Signed-off-by: Jose R. Gonzalez jose@flutes.dev

[acornett21]

Can't main live in /cmd without having a sub folder? cmd/prflight/cmd seems like a weird package path.

[coveralls]

coverage: 83.402%. remained the same
when pulling 19efb51 on komish:move-main-dot-go
into 7a7320f on redhat-openshift-ecosystem:main.

[dcibot]

• FAILURE https://www.distributed-ci.io/jobs/6a0e6217-b782-41aa-9450-7d4a1c406339/jobStates
  from move main.go to be within the cmd directory structure and push all subcommands down one layer #813

[acornett21]

Can't main live in /cmd without having a sub folder? cmd/prflight/cmd seems like a weird package path.

Looking at a few other repos, it looks like this pattern is actually common.

[komish]

Can't main live in /cmd without having a sub folder? cmd/prflight/cmd seems like a weird package path.

I don’t think so. The package for the entry point must be main, but the cobra commands probably shouldn’t live in the main package.

[dcibot]

• SUCCESS https://www.distributed-ci.io/jobs/b66622d0-255d-4273-a860-d0e1a2b422be/jobStates
  from move main.go to be within the cmd directory structure and push all subcommands down one layer #813

[tkrishtop]

hi @komish sorry for the failed job, we got an issue with the folder permissions in Dallas, it is now fixed

[openshift-ci]

@sebrandon1: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bcrochet]

/lgtm

Awesome that the changes were pretty limited and just a 'git mv' in most cases.

[skattoju4]

/lgtm

[openshift-ci]

@skattoju4: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[skattoju]

/lgtm

[dcibot]

• SUCCESS https://www.distributed-ci.io/jobs/22e4757a-1c71-44bd-9c5d-f266aa60d606/jobStates
  from move main.go to be within the cmd directory structure and push all subcommands down one layer #813

[bcrochet]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, komish, sebrandon1, skattoju, skattoju4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bcrochet,komish,skattoju]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment