Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/onsi/gomega from 1.22.1 to 1.23.0 #814

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 26, 2022

Bumps github.com/onsi/gomega from 1.22.1 to 1.23.0.

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.23.0

1.23.0

Features

  • Custom formatting on a per-type basis can be provided using format.RegisterCustomFormatter() -- see the docs here

  • Substantial improvement have been made to StopTrying():

    • Users can now use StopTrying().Wrap(err) to wrap errors and StopTrying().Attach(description, object) to attach arbitrary objects to the StopTrying() error
    • StopTrying() is now always interpreted as a failure. If you are an early adopter of StopTrying() you may need to change your code as the prior version would match against the returned value even if StopTrying() was returned. Going forward the StopTrying() api should remain stable.
    • StopTrying() and StopTrying().Now() can both be used in matchers - not just polled functions.
  • TryAgainAfter(duration) is used like StopTrying() but instructs Eventually and Consistently that the poll should be tried again after the specified duration. This allows you to dynamically adjust the polling duration.

  • ctx can now be passed-in as the first argument to Eventually and Consistently.

Maintenance

  • Bump github.com/onsi/ginkgo/v2 from 2.3.0 to 2.3.1 (#597) [afed901]
  • Bump nokogiri from 1.13.8 to 1.13.9 in /docs (#599) [7c691b3]
  • Bump github.com/google/go-cmp from 0.5.8 to 0.5.9 (#587) [ff22665]
Changelog

Sourced from github.com/onsi/gomega's changelog.

1.23.0

Features

  • Custom formatting on a per-type basis can be provided using format.RegisterCustomFormatter() -- see the docs here

  • Substantial improvement have been made to StopTrying():

    • Users can now use StopTrying().Wrap(err) to wrap errors and StopTrying().Attach(description, object) to attach arbitrary objects to the StopTrying() error
    • StopTrying() is now always interpreted as a failure. If you are an early adopter of StopTrying() you may need to change your code as the prior version would match against the returned value even if StopTrying() was returned. Going forward the StopTrying() api should remain stable.
    • StopTrying() and StopTrying().Now() can both be used in matchers - not just polled functions.
  • TryAgainAfter(duration) is used like StopTrying() but instructs Eventually and Consistently that the poll should be tried again after the specified duration. This allows you to dynamically adjust the polling duration.

  • ctx can now be passed-in as the first argument to Eventually and Consistently.

Maintenance

  • Bump github.com/onsi/ginkgo/v2 from 2.3.0 to 2.3.1 (#597) [afed901]
  • Bump nokogiri from 1.13.8 to 1.13.9 in /docs (#599) [7c691b3]
  • Bump github.com/google/go-cmp from 0.5.8 to 0.5.9 (#587) [ff22665]
Commits
  • bf817a4 v1.23.0
  • 7b8b801 fix broken call to Eventually
  • ba35cc6 Allow ctx to be passed in as a leading parameter for Eventually and Consistently
  • 818b78c AsyncAssertions emit the format.Object representation of the error when it i...
  • d63d67e Rename AsyncSignalError to PollingSignalError
  • abd25f0 fix go vet
  • 618a133 Introduce TryAgainAfter
  • 67ab22c Simplify StopTrying handling
  • 75c8c70 Fix go vet and drop 1.17 from test matrix
  • 237e97d Matchers can now return StopTrying() errors; StopTrying() can wrap an error t...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.22.1 to 1.23.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.22.1...v1.23.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 26, 2022
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2022

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.48% when pulling 23b8fdf on dependabot/go_modules/github.com/onsi/gomega-1.23.0 into 7a7320f on main.

@bcrochet
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2022

@sebrandon1: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, dependabot[bot], sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2022
@acornett21 acornett21 merged commit 86eac68 into main Oct 27, 2022
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/onsi/gomega-1.23.0 branch October 27, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants