Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer send dockerconfigjson if container.HostedRegistry is true #818

Merged
merged 1 commit into from
Oct 31, 2022
Merged

no longer send dockerconfigjson if container.HostedRegistry is true #818

merged 1 commit into from
Oct 31, 2022

Conversation

acornett21
Copy link
Contributor

@acornett21 acornett21 commented Oct 27, 2022

  • Fixes: No Longer Send Docker Config for Red Hat Hosted Registries #817
  • Add in a check container to see if RH hosts the registry, and if so no longer send the dockerconfigjson to pyxis
    • This prevents uploading dockerfiles that clair/registry-proxy would be unable to use to pull the image
  • Added unit tests to cover this logic
  • Manually tested in UAT against projects 6334bcc6580d0bddc451107c and 6334c74d387cd5060b70dce8

Signed-off-by: Adam D. Cornett adc@redhat.com

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 84.49% when pulling f72aa5c on acornett21:add_hosted_registry_flag into 7a7320f on redhat-openshift-ecosystem:main.

Signed-off-by: Adam D. Cornett <adc@redhat.com>
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2022

@sebrandon1: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @acornett21

@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit f9cff77 into redhat-openshift-ecosystem:main Oct 31, 2022
@acornett21 acornett21 deleted the add_hosted_registry_flag branch January 2, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Longer Send Docker Config for Red Hat Hosted Registries
6 participants