Add insecure option to support self-signed and HTTP registries #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
bcrochet
force-pushed
the
fixes/593
branch
2 times, most recently
from
3130828
to
93dcdff
Compare
acornett21
reviewed
Nov 10, 2022
docs/RECIPES.md
Outdated
| ``` | ||
|
|
||
| Note: --submit and --insecure are mutually exclusive. A container cannot be fully | ||
| certified and submit unless it is on a secure registry. |
There was a problem hiding this comment.
Suggested change
| certified and submit unless it is on a secure registry. | |
| certified and submitted unless it is on a secure registry. |
acornett21
approved these changes
Nov 10, 2022
komish
reviewed
Nov 10, 2022
komish
reviewed
Nov 10, 2022
komish
approved these changes
Nov 10, 2022
Without this option, crane would always try to verify the TLS certificates of the registry. This would not allow for self-signed certificates, or registries that only use HTTP. In order to support the workflow to start a registry, push to that local registry, and then pull preflight (think CI system), this option is necessary. This is considered the "official" method for building a local image and testing against it. Fixes redhat-openshift-ecosystem#593 Signed-off-by: Brad P. Crochet <brad@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this option, crane would always try to verify the TLS certificates of the registry. This would not allow for self-signed certificates, or registries that only use HTTP. In order to support the workflow to start a registry, push to that local registry, and then pull preflight (think CI system), this option is necessary.
This is considered the "official" method for building a local image and testing against it.
Fixes #593
Signed-off-by: Brad P. Crochet brad@redhat.com