log validation errors separately in deployableByOLM check #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
openshift-ci
bot
added
the
approved
tkrishtop
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Thank you @komish! We have now a clear error in the logs:
time="2022-12-02T20:22:55Z" level=debug msg="running check: DeployableByOLM"
time="2022-12-02T20:22:57Z" level=trace msg="reading annotations file from the bundle"
time="2022-12-02T20:22:57Z" level=debug msg="image extraction directory is /tmp/preflight-2553569998/fs"
time="2022-12-02T20:22:58Z" level=info msg="check completed: DeployableByOLM" err="the bundle cannot be deployed because deployment validation has failed: [{Name:ibm-mq.v1.3.1 Errors:[Error: Value : (ibm-mq.v1.3.1) olm.maxOpenShiftVersion csv.Annotations not specified with an OCP version lower than 4.9. This annotation is required to prevent the user from upgrading their OCP cluster before they have installed a version of their operator which is compatible with 4.9. For further information see https://docs.openshift.com/container-platform/4.8/operators/operator_sdk/osdk-working-bundle-images.html#osdk-control-compat_osdk-working-bundle-images] Warnings:[Warning: Value ibm-mq.v1.3.1: this bundle is using APIs which were deprecated and removed in v1.22. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-22. Migrate the API(s) for CRD: ([\"queuemanagers.mq.ibm.com\"])]}]" result=ERROR
|
@tkrishtop: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
acornett21
approved these changes
Dec 5, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish, tkrishtop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #844
Preflight executes a pre-deployment validation on the bundle to prevent failures in deployment caused by invalid bundles.
In some cases, the validation logic would return that the bundle is invalid, but this is not considered an error in validation execution so our error returned would be
nil, giving the user no information as to what happened in their deployment. In truth, we hadn't even deployed the bundle yet.This PR fixes this behavior, and now prints out all validation errors in the output in cases where our validation results == failed, but no error was thrown by the validation functions.
Signed-off-by: Jose R. Gonzalez jose@flutes.dev