Merge newly-rebased lib into main #856
Conversation
openshift-ci
bot
added
the
approved
|
golangci-lint was upset about my import ordering so I fixed that and made it its own commit, simply because it touched 17 files 🙄 |
|
/retest |
|
Re E2E Failures: Prow seems to be failing because some logic is creating a directory |
|
@sebrandon1: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/test 4.8-e2e |
|
/retest |
Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
certification/internal was problematic. It cause use to have to expose in some cases thin "wrappers" that were exported in the right place in order to be able to access it. Instead, internal allows the entire module to get to the internal bits. Signed-off-by: Brad P. Crochet <brad@redhat.com>
Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
* Moves certification/engine * Moves certification/pyxis * Moves certification/runtime * Moves certification/policy * Moves certification/artifacts -> artifacts * Moves certification/formatters -> formatters and internal/formatters * Leaves the FormatterFunc type exported * Creates runtime top-level package Signed-off-by: Brad P. Crochet <brad@redhat.com>
By using logr.Logger, it will allow for a library user or the cli to inject a logr that conforms to the logr.Logger interface. This frees up the library from having to do any kind of strange log tricks in order to handle logging. Signed-off-by: Brad P. Crochet <brad@redhat.com>
Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, komish, sebrandon1, skattoju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
🥳 |
|
Great to see this merged into main! Thanks! |
Just three things:
sprintff5852efI left the original lib branch intact so we can use it as a reference, if needed. The first 6 commits here should be aligned with it, barring merge conflicts (which were mostly go mod related)