Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configurable artifacts directory in e2e testing #861

Conversation

komish
Copy link
Contributor

@komish komish commented Jan 4, 2023

  • allows for the configuration of the artifacts directory when executing our e2e operator testing script
  • defaults to a directory NOT called "artifacts", which should help us deal with issues related to our upcoming artifacts package.

Signed-off-by: Jose R. Gonzalez jose@flutes.dev

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@coveralls
Copy link

coveralls commented Jan 4, 2023

Coverage Status

Coverage: 84.438% (+0.0%) from 84.438% when pulling 64504e8 on komish:add-configurable-artifacts-in-e2e into 174eea6 on redhat-openshift-ecosystem:main.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2023
@acornett21
Copy link
Contributor

/test 4.8-e2e

1 similar comment
@acornett21
Copy link
Contributor

/test 4.8-e2e

Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
@komish komish force-pushed the add-configurable-artifacts-in-e2e branch from fad5792 to 64504e8 Compare January 5, 2023 15:30
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
Copy link
Contributor

@skattoju skattoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, komish, skattoju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,komish,skattoju]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit bdbb21e into redhat-openshift-ecosystem:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants