Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating git ignore to ignore files outputted by check operator cmd #863

Merged
merged 1 commit into from
Jan 6, 2023
Merged

updating git ignore to ignore files outputted by check operator cmd #863

merged 1 commit into from
Jan 6, 2023

Conversation

acornett21
Copy link
Contributor

  • Updating the gitignore so we do not accidentally check in output files.

Signed-off-by: Adam D. Cornett adc@redhat.com

@acornett21
updating git ignore to ignore files outputted by check operator cmd
92e4bad 
Signed-off-by: Adam D. Cornett <adc@redhat.com>
@acornett21 acornett21 requested a review from komish January 6, 2023 18:23
@openshift-ci openshift-ci bot requested a review from jomkz January 6, 2023 18:27
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2023
@coveralls
Copy link

Coverage Status

Coverage: 81.897%. Remained the same when pulling 92e4bad on acornett21:update_git_ignore into 2186885 on redhat-openshift-ecosystem:main.

skattoju
skattoju approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@skattoju skattoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2023
@dcibot
Copy link

dcibot commented Jan 6, 2023

komish
komish approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, komish, skattoju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,komish,skattoju]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 8755b37 into redhat-openshift-ecosystem:main Jan 6, 2023
@acornett21 acornett21 deleted the update_git_ignore branch January 2, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komish komish komish approved these changes

@skattoju skattoju skattoju approved these changes

@jomkz jomkz Awaiting requested review from jomkz

Assignees

@komish komish

@skattoju skattoju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@acornett21 @coveralls @dcibot @komish @skattoju