Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to the latest operator-sdk 1.26.0 #864

Merged

Conversation

tkrishtop
Copy link
Contributor

@tkrishtop tkrishtop commented Jan 9, 2023

Signed-off-by: Tatiana Krishtop tkrishto@redhat.com

That should allow for getting more detailed error messages when the scorecard-sdk times out.

Signed-off-by: Tatiana Krishtop <tkrishto@redhat.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2023

Hi @tkrishtop. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage: 81.897%. Remained the same when pulling e12ab76 on tkrishtop:operator_sdk_1_26 into 8755b37 on redhat-openshift-ecosystem:main.

@tkrishtop
Copy link
Contributor Author

Regular contributors should join the org to skip this step.

Hi @acornett21, do you know who to ping to join?

@acornett21
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2023
@acornett21
Copy link
Contributor

@tkrishtop I'm not sure who owns the redhat-openshift-ecosystem org.

@jomkz Do you happen to know?

@bcrochet
Copy link
Contributor

bcrochet commented Jan 9, 2023

Would love to wait for this to land: operator-framework/operator-sdk#6187

But understand if there is a more pressing need to bump this.

@tkrishtop

@tkrishtop
Copy link
Contributor Author

tkrishtop commented Jan 9, 2023

Would love to wait for this to land: operator-framework/operator-sdk#6187

But understand if there is a more pressing need to bump this.

@tkrishtop

Oh, 4.12 security labels, I had to add them as well to run the preflight check on 4.12, it's nice to know that the proper solution is coming.

@bcrochet thanks for checking the PR! I'm not sure how long we'll have to wait for #6187 to be merged. The discussion has been ongoing for 2 months already. I'd prefer to merge 1.26.0 and move forward with these annoying scorecard timeouts - they happen all the time when you run 20 preflight check operator in one job. I tested my change on the latest GA for 4.11, and everything looks safe.

@bcrochet
Copy link
Contributor

Would love to wait for this to land: operator-framework/operator-sdk#6187
But understand if there is a more pressing need to bump this.
@tkrishtop

Oh, 4.12 security labels, I had to add them as well to run the preflight check on 4.12, it's nice to know that the proper solution is coming.

@bcrochet thanks for checking the PR! I'm not sure how long we'll have to wait for #6187 to be merged. The discussion has been ongoing for 2 months already. I'd prefer to merge 1.26.0 and move forward with these annoying scorecard timeouts - they happen all the time when you run 20 preflight check operator in one job. I tested my change on the latest GA for 4.11, and everything looks safe.

Fair enough.

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, tkrishtop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 7d2d41a into redhat-openshift-ecosystem:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants