allow results and log writing to overwrite existing content on re-run of preflight #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
… of preflight Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
komish
force-pushed
the
remove-safe-write
branch
from
9a5c4a0
to
a39ec24
Compare
acornett21
approved these changes
Jan 16, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #827
In version 1.4.0, Preflight would overwrite existing results.json, etc. within the artifacts directory on re-execution. This behavior changed in version 1.4.1 with the introduction of Afero which is causing some friction for users.
This PR should return the original behavior back until we decide what we want to do re: artifacts writing in the future.
Signed-off-by: Jose R. Gonzalez jose@flutes.dev