Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typo in log message #875

Merged
merged 1 commit into from
Jan 27, 2023
Merged

chore: fix typo in log message #875

merged 1 commit into from
Jan 27, 2023

Conversation

sxd
Copy link
Contributor

@sxd sxd commented Jan 27, 2023

Currently the message once this image was tied to the container image sha256 digest, this put just an space for easy reading and parsing.

Signed-off-by: Jonathan Gonzalez V jonathan.gonzalez@enterprisedb.com

@sxd
chore: fix typo in log message
49e38fe 
Currently the message `once this image` was tied to the container image
sha256 digest, this put just an space for easy reading and parsing.

Signed-off-by: Jonathan Gonzalez V <jonathan.gonzalez@enterprisedb.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

Hi @sxd. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcibot
Copy link

dcibot commented Jan 27, 2023

@komish
Copy link
Contributor

komish commented Jan 27, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2023
@coveralls
Copy link

Coverage Status

Coverage: 81.826%. Remained the same when pulling 49e38fe on sxd:fix_typo into 9e2b88b on redhat-openshift-ecosystem:main.

komish
komish approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @sxd

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, komish, sxd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 4416861 into redhat-openshift-ecosystem:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komish komish komish approved these changes

@acornett21 acornett21 acornett21 approved these changes

@skattoju skattoju Awaiting requested review from skattoju

Assignees

@komish komish

@acornett21 acornett21

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sxd @dcibot @komish @coveralls @acornett21