configure the insecure flag to allow access to registries with self-signed certificate #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igned certificate Signed-off-by: Jose R. Gonzalez <jrg@redhat.com>
openshift-ci
bot
added
the
approved
acornett21
approved these changes
Feb 3, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish, skattoju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bit of a behavioral difference in the crane library execution compared to its CLI that causes us to have a bug in how we handle our insecure flag. See google/go-containerregistry#1553 for full context.
In effect, we allowed access to registries available via HTTP, but not HTTPS registries with untrusted certificates.
In testing, I also found a bug where we didn't fully initialize the the CraneEngine by passing it the insecure flag when received by the caller.
This PR resolves both issues.
Signed-off-by: Jose R. Gonzalez jrg@redhat.com