Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update operator-sdk to 1.22.1 #135

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Update operator-sdk to 1.22.1 #135

merged 1 commit into from
Jul 15, 2022

Conversation

bcrochet
Copy link
Contributor

In doing so, this patch also goes back to 1.15.0 (which I think is
where we started), and applies all of the migrations that are specified
at https://sdk.operatorframework.io/docs/upgrading-sdk-version/
It should be noted that in the future, this should be check every
time operator-sdk is updated here.

Signed-off-by: Brad P. Crochet brad@redhat.com

komish
komish requested changes Jul 14, 2022
View reviewed changes
Copy link

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some notes of things I think we may not be intending to change. The changes I noted may have been intentional, but I'm just remembering back to the times where I bump opsdk and have to manually go through and fix these things.

komish
komish approved these changes Jul 14, 2022
View reviewed changes
Copy link

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2022
acornett21
acornett21 reviewed Jul 14, 2022
View reviewed changes
bundle/metadata/annotations.yaml Outdated Show resolved Hide resolved
bundle.Dockerfile Outdated Show resolved Hide resolved
bundle/metadata/dependencies.yaml Outdated
@@ -2,4 +2,4 @@ dependencies:
- type: olm.package
value:
packageName: openshift-pipelines-operator-rh
version: "1.5.2"
version: "1.7.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to test this version with our operator as a bundle/catalog in a net new cluster, to make sure the issues in 1.6.x versions were actually fixed.

Copy link
Contributor Author

@bcrochet bcrochet Jul 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran some local tests on a brand-new SNO cluster. I was able to do a pipeline run (the operator I passed itself failed the validation) the pipeline run completed. Would definitely welcome further testing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test this as well, and OCO installed properly, as did operator-pipelines. I poked the cluster some, events and logs from both OLM operators and didn't see any errors/warns, so I think they fixed all the 1.6.x issues for the things we care about and need.

bundle/manifests/operator-certification-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2022

@bcrochet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2022
@bcrochet
Update operator-sdk to 1.22.1
03f03df 
In doing so, this patch also goes back to 1.15.0 (which I think is
where we started), and applies all of the migrations that are specified
at https://sdk.operatorframework.io/docs/upgrading-sdk-version/
It should be noted that in the future, this should be check every
time operator-sdk is updated here.

Signed-off-by: Brad P. Crochet <brad@redhat.com>
komish
komish approved these changes Jul 15, 2022
View reviewed changes
Copy link

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2022
@acornett21 acornett21 merged commit 070a377 into redhat-openshift-ecosystem:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komish komish komish approved these changes

@acornett21 acornett21 acornett21 approved these changes

@mrhillsman mrhillsman Awaiting requested review from mrhillsman

Assignees

@komish komish

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcrochet @komish @acornett21 @openshift-merge-robot