Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding scc, role, rolebinding logic #144

Merged
merged 1 commit into from
May 16, 2023
Merged

adding scc, role, rolebinding logic #144

merged 1 commit into from
May 16, 2023

Conversation

acornett21
Copy link
Contributor

  • Adds logic to add SCC, ClusterRole, and ClusterRole binding that exist in operator-pipelines repo that are needed to support newer version of tekton operator.
  • Adds finalizer to our CR so we can probably remove these cluster scoped resources in the case of multiple OperatorPipelines CustomResources
  • Fixes: Add Pipelines SCC and Update Pipeline SA to Reference new SCC #143

@openshift-ci openshift-ci bot requested a review from mrhillsman May 10, 2023 17:28
komish
komish requested changes May 10, 2023
View reviewed changes
Copy link

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just recommending a couple of changes, nothing major.

@acornett21
adding scc, role, rolebinding logic
ef4284c 
Signed-off-by: Adam D. Cornett <adc@redhat.com>
bcrochet
bcrochet approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
komish
komish approved these changes May 16, 2023
View reviewed changes
Copy link

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acornett21 acornett21 merged commit f9d62a3 into redhat-openshift-ecosystem:main May 16, 2023
@acornett21 acornett21 deleted the add_scc_logic branch January 2, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet approved these changes

@komish komish komish approved these changes

@mrhillsman mrhillsman Awaiting requested review from mrhillsman

Assignees

@bcrochet bcrochet

@komish komish

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Pipelines SCC and Update Pipeline SA to Reference new SCC
3 participants
@acornett21 @bcrochet @komish