Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding golangci linting to project and correcting all errors found #145

Merged
merged 1 commit into from
May 22, 2023
Merged

adding golangci linting to project and correcting all errors found #145

merged 1 commit into from
May 22, 2023

Conversation

acornett21
Copy link
Contributor

  • Adding linting to this project
  • Followed preflights format/layout
  • Fixed any issues that were outputted

@acornett21 acornett21 requested a review from bcrochet May 10, 2023 22:10
bcrochet
bcrochet reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions.

api/v1alpha1/groupversion_info.go Show resolved Hide resolved
controllers/operatorpipeline_controller.go Show resolved Hide resolved
@acornett21 acornett21 force-pushed the add_go_linting branch 9 times, most recently from f7bdac4 to 4983f4e Compare May 18, 2023 19:06
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2023
@acornett21
adding golangci linting to project and correcting all errors found
2a47513 
Signed-off-by: Adam D. Cornett <adc@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2023
komish
komish approved these changes May 22, 2023
View reviewed changes
Copy link

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

There's one question I had on an existing thread. Otherwise, looks fine.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@acornett21 acornett21 merged commit ca2a077 into redhat-openshift-ecosystem:main May 22, 2023
@acornett21 acornett21 deleted the add_go_linting branch January 2, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet left review comments

@komish komish komish approved these changes

@mrhillsman mrhillsman Awaiting requested review from mrhillsman

@skattoju skattoju Awaiting requested review from skattoju

Assignees

@komish komish

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acornett21 @bcrochet @komish @openshift-merge-robot