Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing deps and fix pep8 #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nfv_tempest_plugin/tests/common/shell_utilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ def get_value_from_ini_config(overcloud_node, config_path,
class M(OrderedDict):
def __setitem__(self, key, value):
v_val = self.get(key)
if v_val is not None and type(value) == list:
if v_val is not None and isinstance(value, list):
v_val.append(value[0])
else:
v_val = value
Expand Down
2 changes: 1 addition & 1 deletion nfv_tempest_plugin/tests/scenario/baremetal_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ def _create_test_networks(self):
if 'pool_start' in net_param:
network_kwargs['allocation_pools'] = \
[{'start': net_param['pool_start'],
'end':net_param['pool_end']}]
'end': net_param['pool_end']}]
if 'dns_nameservers' in net_param:
network_kwargs['dns_nameservers'] = \
net_param['dns_nameservers']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def test_igmp_snooping_deployment(self, test='igmp_snooping_deployment'):

for check in checks:
if check in diff_checks_cmd:
if type(ovs_data_filt[check]) == str:
if isinstance(ovs_data_filt[check], str):
# If object is not equal to 'true' or 'false'
# ValueError exception will be raised
ovs_data_filt[check] = \
Expand Down
4 changes: 2 additions & 2 deletions nfv_tempest_plugin/tests/scenario/test_nfv_offload.py
Original file line number Diff line number Diff line change
Expand Up @@ -535,9 +535,9 @@ def test_offload_tcp_conntrack_trunk_vlan(

def test_offload_tcp_conntrack_transparent_vlan(
self, test='offload_tcp_conntrack_transparent_vlan'):
"""Check TCP traffic is offloaded in transparent vlan network with sec groups
"""Check TCP traffic is offloaded in transparent vlan network

The following test deploy vms, on hw-offload computes.
with sec groups. The following test deploy vms, on hw-offload computes.
Vms have security groups enabled.
It sends Ttcp traffic and check conntrack table to check if flows
are offloaded
Expand Down
4 changes: 3 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ python-novaclient==17.4.0
metalsmith
paramiko==2.11.0
# openstack-tempest/requirements.txt:jsonschema>=3.2.0 # MIT
# current version 4.0.0 is breaking aggregates client
# current version 4.0.0 is breaking aggregates client
# validation
jsonschema==3.2.0 # MIT
cryptography==3.3.2
tempest>=27.0.0 # Apache-2.0
neutron_tempest_plugin>=0.9.0 # Apache-2.0
9 changes: 6 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
minversion = 2.3.1
envlist = py27,pep8
minversion = 3.18.0
envlist = py3,pep8
skipsdist = True

# info: to run individual tests/ testcase,
Expand All @@ -12,7 +12,10 @@ usedevelop = True
setenv =
VIRTUAL_ENV={envdir}
PYTHONWARNINGS=default::DeprecationWarning
deps = -r{toxinidir}/test-requirements.txt
allowlist_externals = find
deps =
-r{toxinidir}/requirements.txt
-r{toxinidir}/test-requirements.txt
commands =
# Cleanup cache files to avoid failures when running tox on developer env.
find . -type f -name "*.pyc" -delete
Expand Down