spec: used macro for profiles path and other fixes #665
Conversation
yarda
commented
Jul 26, 2024
yarda
commented
- improved conditionals for better readability
- fixed tuned-ppd not to run install twice
- used macro for profiles path
yarda
force-pushed
the
spec-profile-paths-macro
branch
2 times, most recently
from
2652a28
to
05bf7bb
Compare
|
The changes look fine to me and the RPM build/installation works well. The failed CI tests do not seem related to the changes, though I'm not sure what's causing them. Approving. |
|
/packit build |
yarda
force-pushed
the
spec-profile-paths-macro
branch
from
05bf7bb
to
5995ef7
Compare
|
Rebased and hopefully fixed not to break the CI now :) |
yarda
force-pushed
the
spec-profile-paths-macro
branch
6 times, most recently
from
196635e
to
efd84e4
Compare
|
It was a bit more tricky than I initially thought :). It seems I will also have to fix tests. |
yarda
force-pushed
the
spec-profile-paths-macro
branch
from
efd84e4
to
5580fbc
Compare
|
It also requires: beakerlib/tuned#10 |
yarda
force-pushed
the
spec-profile-paths-macro
branch
2 times, most recently
from
788be03
to
30c6f94
Compare
|
@zacikpa please re-review. |
| rlServiceStop "tuned" | ||
| sleep 1 | ||
| rlFileBackup "/var/log/tuned/tuned.log" | ||
| rlRun "rm -rf /var/log/tuned/tuned.log" | ||
| rlFileBackup "/var/log/tuned/tuned.log" | ||
| rlRun "rm -rf /var/log/tuned/tuned.log" | ||
| rlServiceStart "tuned" |
There was a problem hiding this comment.
Why separate the service stop? I'd back up the logs first and then run rlServiceStart (which restarts TuneD if it's already running).
There was a problem hiding this comment.
It's taken from the RHEL dist-git upstream Beaker test. I wanted to sync to their version. IMHO it's trying to avoid possible race if the daemon is simultaneously logging while the file is removed/backed-up. Without it IMHO the worst case that could happen is that for multiline logs there could be some lines missing in the log (IMHO it uses line buffering). But the calls in the test could be reordered.
There was a problem hiding this comment.
Ok, let's keep the tests in sync.
- improved conditionals for better readability - fixed tuned-ppd not to run install twice - used macro for profiles path - consolidated names of related variables - updated Makefile to update the current profile paths during installation - fixed tests to use correct profile directory on RHEL/CentOS - consolidated whitespaces and variable names in fixed tests Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
yarda
force-pushed
the
spec-profile-paths-macro
branch
from
30c6f94
to
7a41949
Compare
