Clear plugin repository when stopping tuning #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, good catch. Please link the corresponding Jira ticket. I think it's worth to get it into the stable release. |
zacikpa
force-pushed
the
repo-remove-old-plugins
branch
from
49310da
to
017cf59
Compare
Not clearing it before a profile switch would result in never deleting the original plugin objects - those would accumulate in memory with each profile switch. Relates: RHEL-36442
zacikpa
force-pushed
the
repo-remove-old-plugins
branch
from
017cf59
to
f8858f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not clearing it before a profile switch would
result in never deleting the original plugin
objects - those would accumulate in memory with
each profile switch.
TBH, I believe we could get rid of the plugin repository
class altogether, I'm not quite sure what's its responsibility
and why we need it when we have the plugin manager.