Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle cases when config isn't defined 🔧 #156

Merged
merged 6 commits into from
Dec 13, 2022

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Dec 7, 2022

No description provided.

@jamacku jamacku self-assigned this Dec 7, 2022
@jamacku jamacku linked an issue Dec 7, 2022 that may be closed by this pull request
@mergify mergify bot added the source label Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #156 (bad5215) into main (2921d9e) will increase coverage by 13.36%.
The diff coverage is 96.42%.

@@             Coverage Diff             @@
##             main     #156       +/-   ##
===========================================
+ Coverage   63.71%   77.07%   +13.36%     
===========================================
  Files           5        5               
  Lines         463      506       +43     
  Branches       48       87       +39     
===========================================
+ Hits          295      390       +95     
+ Misses        168      116       -52     
Impacted Files Coverage Δ
src/labeler.ts 58.54% <93.10%> (+23.84%) ⬆️
src/config.ts 91.06% <100.00%> (+8.57%) ⬆️
src/inputs.ts 100.00% <100.00%> (+15.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jamacku jamacku force-pushed the fix-no-config-issue branch from da8d03e to be00dc2 Compare December 9, 2022 15:07
@mergify mergify bot added the test label Dec 9, 2022
@jamacku jamacku added this to the v2.0.2 milestone Dec 12, 2022
@jamacku jamacku force-pushed the fix-no-config-issue branch from 9b471dc to 0a1a95b Compare December 12, 2022 19:47
@jamacku jamacku force-pushed the fix-no-config-issue branch from 0a1a95b to 61cdde6 Compare December 12, 2022 19:59
@jamacku jamacku force-pushed the fix-no-config-issue branch from 756d397 to 021e4e4 Compare December 13, 2022 09:38
@jamacku jamacku force-pushed the fix-no-config-issue branch from 021e4e4 to bad5215 Compare December 13, 2022 11:34
@jamacku jamacku merged commit ecf3f89 into redhat-plumbers-in-action:main Dec 13, 2022
@jamacku jamacku deleted the fix-no-config-issue branch December 13, 2022 11:40
@jamacku jamacku mentioned this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if labels can be set when configuration is missing
1 participant