Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node.js 16 and use Node.js 20 🐢 #119

Merged
merged 5 commits into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/linters/.jscpd.json

This file was deleted.

10 changes: 0 additions & 10 deletions .github/linters/.markdown-lint.yml

This file was deleted.

11 changes: 0 additions & 11 deletions .github/linters/.yaml-lint.yml

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16.x, 18.x]
node-version: [18.x, 20.x]

steps:
- uses: actions/checkout@v4
Expand All @@ -42,5 +42,5 @@ jobs:
run: yarn jest -c jest.ci.config.js --coverage

- name: Codecov
if: ${{ matrix.node-version == '18.x' }}
if: ${{ matrix.node-version == '20.x' }}
uses: codecov/codecov-action@v3
24 changes: 2 additions & 22 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,6 @@ permissions:
contents: read

jobs:
super-linter:
name: Super Linter
runs-on: ubuntu-latest

steps:
- name: Repository checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Lint Code Base
uses: github/super-linter@v5
env:
VALIDATE_ALL_CODEBASE: false
DEFAULT_BRANCH: main
VALIDATE_JAVASCRIPT_STANDARD: false
VALIDATE_TYPESCRIPT_STANDARD: false
VALIDATE_BASH: false
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

prettier-and-eslint:
name: Prettier & ESLint
runs-on: ubuntu-latest
Expand All @@ -40,10 +20,10 @@ jobs:
- name: Repository checkout
uses: actions/checkout@v4

- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
cache: yarn

- name: Install
Expand Down
138 changes: 0 additions & 138 deletions .mergify.yml

This file was deleted.

8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import BugzillaAPI from "bugzilla";
let api = new BugzillaAPI(
"https://bugzilla.mozilla.org",
"<username>",
"<password>"
"<password>",
);
await api.version();
```
Expand All @@ -54,12 +54,12 @@ Or any advanced search which can be passed in a number of ways:
```javascript
// You can just pass a full advanced search url:
let bugs = await api.advancedSearch(
"https://bugzilla.mozilla.org/buglist.cgi?email1=dtownsend%40mozilla.com&emailassigned_to1=1&resolution=---&emailtype1=exact&list_id=15603348"
"https://bugzilla.mozilla.org/buglist.cgi?email1=dtownsend%40mozilla.com&emailassigned_to1=1&resolution=---&emailtype1=exact&list_id=15603348",
);

// Or just the query string part:
let bugs = await api.advancedSearch(
"email1=dtownsend%40mozilla.com&emailassigned_to1=1&resolution=---&emailtype1=exact&list_id=15603348"
"email1=dtownsend%40mozilla.com&emailassigned_to1=1&resolution=---&emailtype1=exact&list_id=15603348",
);

// Or as a record:
Expand Down Expand Up @@ -115,7 +115,7 @@ Return value is array of Comment objects.
let comment = await api.createComment(
123456,
"This is new comment on bug #123456",
{ is_private: false }
{ is_private: false },
);
```

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@mossop/config": "1.2.3",
"@types/jest": "29.5.5",
"@types/luxon": "3.3.2",
"@types/node": "18.18.4",
"@types/node": "^20.8.4",
"@typescript-eslint/eslint-plugin": "6.7.5",
"@typescript-eslint/parser": "6.7.5",
"eslint": "8.51.0",
Expand Down
2 changes: 1 addition & 1 deletion renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["config:base"],

"labels": ["type: dependencies", "merge-strategy: rebase"],
"labels": ["type: dependencies"],
"github-actions": {
"extends": ["schedule:monthly"],
"addLabels": ["github-actions"]
Expand Down
5 changes: 4 additions & 1 deletion src/link.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,10 @@ export class PublicLink extends BugzillaLink {
* Handles authentication using an API key.
*/
export class ApiKeyLink extends BugzillaLink {
public constructor(instance: URL, private readonly apiKey: string) {
public constructor(
instance: URL,
private readonly apiKey: string,
) {
super(instance);
}

Expand Down
Loading