Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(RHEL-18302) coredump: actually store parsed unit in the context #433

Merged
merged 1 commit into from
Mar 6, 2024
Merged

(RHEL-18302) coredump: actually store parsed unit in the context #433

merged 1 commit into from
Mar 6, 2024

Conversation

msekletar
Copy link
Member

@msekletar msekletar commented Mar 4, 2024 •
edited by github-actions bot
Loading

RHEL-only

Related: RHEL-18302

@github-actions github-actions bot changed the title (#RHEL-18302) coredump: actually store parsed unit in the context (RHEL-18302) coredump: actually store parsed unit in the context Mar 4, 2024
@github-actions github-actions bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Mar 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

Commit validation

Tracker - RHEL-18302

The following commits meet all requirements

commit upstream
7404669 - coredump: actually store parsed unit in the context RHEL-only

Tracker validation

Success

🟢 Tracker RHEL-18302 has set desired product: rhel-8.4.0
🟢 Tracker RHEL-18302 has set desired component: systemd
🟢 Tracker RHEL-18302 has been approved

Pull Request validation

Success

🟡 CI - Waived
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

Auto Merge

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟠 Pull Request meet requirements, mergeable_state is unstable
🟢 Pull Request has correct target branch main
🟢 Pull Request was merged

@dtardon
Copy link
Member

dtardon commented Mar 5, 2024

Oops...

dtardon
dtardon approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the pr/needs-review Formerly needs-review label Mar 5, 2024
@msekletar
Copy link
Member Author

Unit test failures look unrelated, @mrc0mmand can you please double check and confirm?

@mrc0mmand
Copy link
Member

mrc0mmand commented Mar 6, 2024 •
edited
Loading

Unit test failures look unrelated, @mrc0mmand can you please double check and confirm?

It seems unrelated, but still new. I'll check what's going on, in case the fix is simple.

@mrc0mmand
Copy link
Member

I'll waive the CI, since resolving this would require a bit of fiddling around.

@github-actions github-actions bot removed the pr/needs-ci Formerly needs-ci label Mar 6, 2024
@github-actions github-actions bot merged commit ccaa361 into redhat-plumbers:main Mar 6, 2024
7 of 9 checks passed
@mrc0mmand mrc0mmand mentioned this pull request Mar 6, 2024
Open
@mrc0mmand
Copy link
Member

I'll waive the CI, since resolving this would require a bit of fiddling around.

Just FTR, I filed the issue as #434, since we'll most likely hit it again with later PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtardon dtardon dtardon approved these changes

Assignees
No one assigned
Labels
ci-waived released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msekletar @dtardon @mrc0mmand @jamacku