Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-19215) logind: don't setup idle session watch for lock-screen and greeter #441

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

msekletar
Copy link
Member

@msekletar msekletar commented Nov 5, 2024

Reason to skip the idle session logic for these session classes is that
they are idle by default.

(cherry picked from commit 508b4786e8592e82eb4832549f74aaa54335d14c)

Resolves: RHEL-19215

Reason to skip the idle session logic for these session classes is that
they are idle by default.

(cherry picked from commit 508b4786e8592e82eb4832549f74aaa54335d14c)

Resolves: RHEL-19215
Copy link

github-actions bot commented Nov 5, 2024

Commit validation

Tracker - RHEL-19215

The following commits meet all requirements

commit upstream
9701aa0 - logind: don't setup idle session watch for lock-screen and greeter systemd/systemd@508b478
5a406df - logind: tighten for which classes of sessions we do stop-on-idle systemd/systemd@ad23439

Tracker validation

Success

🟢 Tracker RHEL-19215 has set desired product: rhel-8.8.0
🟢 Tracker RHEL-19215 has set desired component: systemd
🟢 Tracker RHEL-19215 has been approved
🟢 Tracker RHEL-19215 has set severity


Pull Request validation

Success

🟡 CI - Waived
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Failed

🔴 Pull Request has unsupported target branch rhel-8.10.0, expected branches are: 'main,master'

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟠 Pull Request meet requirements, mergeable_state is unstable

@mrc0mmand
Copy link
Member

CI fails are known issues (#434, #440).

@github-actions github-actions bot removed the pr/needs-ci Formerly needs-ci label Nov 6, 2024
We only want to do this for fully set up, interactive sessions, i.e.
user and user-early, but not for any others, hence restrict the rules a
bit.

Follow-up for: 508b4786e8592e82eb4832549f74aaa54335d14c

(cherry picked from commit ad23439eae718ac3634f260be0d29e01445983a8)

Related: RHEL-19215
Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the pr/needs-review Formerly needs-review label Nov 6, 2024
@jamacku jamacku merged commit 77a215e into redhat-plumbers:rhel-8.10.0 Nov 6, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants