Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2176918) core: backport OOMPolicy fixes #149

Merged
merged 7 commits into from
Mar 11, 2023

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Mar 10, 2023

Resolves: #2176918

drvink and others added 7 commits March 10, 2023 09:08
Closes #25376.

(cherry picked from commit 5fa0983)

Resolves: #2176918
If the kernel OOM kills a process under a login session scope, we don't want to
kill the user's other processes for no good reason.

(cherry picked from commit 98b6c94)

Resolves: #2176918
One had to read to the very end of the long description to notice that
the setting is actually primarily intended for oomd. So let's mention oomd
right at the beginning.

(cherry picked from commit 100d37d)

Resolves: #2176918
Fixup for 5fa0983.

(cherry picked from commit d5a1657)

Resolves: #2176918
Put fuzzer tests into dictionary that maps `fuzzer->list of inputs`
instead of the flat list.
This is just refactoring with no intentional .

(cherry picked from commit 7db5761)

Related: #2176918
The lists of directives for fuzzer tests are maintained manually in the
repo. There is a tools/check-directives.sh script that runs during test
phase and reports stale directive lists.
Let's rework the script into a generator so that these directive files
are created on-the-flight and needn't be updated whenever a unit file
directives change. The scripts is rewritten in Python to get rid of gawk
dependency and each generated file is a separate meson target so that
incremental builds refresh what is just necessary (and parallelize
(negligible)).

Note: test/fuzz/fuzz-unit-file/directives-all.slice is kept since there
is not automated way to generate it (it is not covered by the check
script neither).

(cherry picked from commit 7e343b5)

Related: #2176918
Since the files with generated directives are now automatically
generated during build, they're now under the respective build directory
which the current oss-fuzz CI script didn't account for.

Follow-up to: #24958
Fixes: #25859

(cherry picked from commit bef8d18)

Related: #2176918
@jamacku jamacku added this to the RHEL-9.3.0 milestone Mar 10, 2023
@jamacku jamacku requested a review from dtardon March 10, 2023 08:12
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Mar 10, 2023
@systemd-rhel-bot systemd-rhel-bot added the pr/needs-review Formerly needs-review label Mar 10, 2023
@systemd-rhel-bot systemd-rhel-bot changed the title core: backport OOMPolicy fixes (#2176918) core: backport OOMPolicy fixes Mar 10, 2023
Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants