FCCEUD-80 Content checklist for Pantheon 2/Jupiter #627
Conversation
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
============================================
- Coverage 52.85% 52.44% -0.42%
+ Complexity 528 527 -1
============================================
Files 156 154 -2
Lines 5165 5076 -89
Branches 799 785 -14
============================================
- Hits 2730 2662 -68
+ Misses 2300 2287 -13
+ Partials 135 127 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Please add FCCEUD-80 to the beginning of the PR title. It makes it easier for me to search for FCCEUD PRs. |
RichardHoch
changed the title
There was a problem hiding this comment.
Looks ok to me. However, I would like @xdavidson to have a look as well
| *Not supported* | ||
|
|
||
| `:leveloffset: +1 | ||
| modules/core-services/proc_registering-the-system-after-the-installation.adoc[leveloffset: -1]` |
There was a problem hiding this comment.
Looks like include:: is missing at the beginning of this line
There was a problem hiding this comment.
@noopurmath3 , it does look like 'include::' is missing on line 34
There was a problem hiding this comment.
I copied what was written in https://docs.engineering.redhat.com/pages/viewpage.action?pageId=173289387 -- see the "Avoid Unsupported includes" section. I am checking with the person who wrote the document and will copy you. .
| *Not supported* | ||
|
|
||
| `:leveloffset: +1 | ||
| modules/core-services/proc_registering-the-system-after-the-installation.adoc[leveloffset: -1]` |
There was a problem hiding this comment.
Lisa is correct, the include is missing. Also, the leveloffset: -1 should be on it's own line
| modules/core-services/proc_registering-the-system-after-the-installation.adoc[leveloffset: -1]` | |
| modules/core-services/proc_registering-the-system-after-the-installation.adoc | |
| leveloffset: -1 |
There was a problem hiding this comment.
Great --- will fix and resubmit.
There was a problem hiding this comment.
Like this? Maybe I didn't understand -- it still looks odd to me.
Not supported
:leveloffset: +1 include::modules/core-services/proc_registering-the-system-after-the-installation.adoc leveloffset: -1
There was a problem hiding this comment.
:leveloffset: +1 + include::modules/core-services/proc_registering-the-system-after-the-installation.adoc + leveloffset: -1
GitHub is erasing my hard returns (+)
There was a problem hiding this comment.
Like this? Maybe I didn't understand -- it still looks odd to me.
Not supported
:leveloffset: +1 include::modules/core-services/proc_registering-the-system-after-the-installation.adoc leveloffset: -1
In asciidoc, if you have a bunch of includes with no leveloffset like include::some-module.adoc[] and put them in between :leveloffset: +1 and :leveloffset: -1, they will all inherit leveloffset=+1, as if you had all of the includes formatted like this include::modules/core-services/proc_registering-the-system-after-the-installation.adoc[leveloffset=+1]. Unfortunately, it’s not supported as far as we know.
link to asciidoc manual https://docs.asciidoctor.org/asciidoc/latest/directives/include-with-leveloffset/
hope this clarifies
RichardHoch
changed the title
|
@xdavidson and @Levi-Leah, please check lines 33 and forward. |
xref support in pantheon 2 is different from that in Jupiter. Pantheon2 implemented its own xref macro to use path based xref target when modules are included in an assembly. This is an unsupported bahviour in upstream asciidoctor community. |
Resolves https://issues.redhat.com/browse/FCCEUD-80
Adds content checklist for Pantheon 2/Jupiter to online help.