Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto reload to dev setup #24

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Add auto reload to dev setup #24

merged 1 commit into from
Jun 24, 2024

Conversation

F-X64
Copy link
Member

@F-X64 F-X64 commented Jun 24, 2024

Small changes to enable auto reload for the compose based development environment.
This will ease the development process by reloading changes within the monitored mounted volume.

Changes:
Remove entrypoint script
Add uvicorn command to Dockerfile
Add uvicorn command to compose
Add reload flag to compose
Add volume mount to compose

@F-X64 F-X64 requested a review from major June 24, 2024 07:49
Copy link
Member

@major major left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Looks like the quality check had a virtualenv issue. Re-running it now...

Dockerfile Show resolved Hide resolved
Remove entrypoint script
Add uvicorn command to Dockerfile
Add uvicorn command to compose
Add reload flag to compose
Add volume mount to compose
Copy link
Member

@major major left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das ist gut! 👏

@major major merged commit 2cc8f5a into main Jun 24, 2024
3 checks passed
@major major deleted the improve-dev-setup branch June 24, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants