Dep compatibility #1171
Closed
Dep compatibility #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, but this is considerable amount of work and demand is not high. I've migrated all projects to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1148, #1143
Currently if you try to use dep with go-redis v7, dep will place the files in
./vendor/github.com/go-redis/redis, and then error because the imports,github.com/go-redis/redis/v7, are mismatched with file locations. Dep minimal module awareness issue: golang/dep#1962Go files have been moved to the top-level into the "v7" subdirectory. This makes it possible to use go-redis v7 with the dep dependency manager, and still compatible with go modules. dep places files on disk at "./github.com/go-redis/redis/v7".
The
forward.gofile is generated using goforward (https://go-review.googlesource.com/c/tools/+/137076/) to add aliases that point to github.com/go-redis/redis to github.com/go-redis/redis/v7. The goforward tool is mentioned in this section https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher