Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update go mod before testing(go mod tidy) #2423

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

monkey92t
Copy link
Collaborator

No description provided.

Signed-off-by: monkey92t <golang@88.com>
@monkey92t monkey92t changed the title test: test: update go mod before testing(go mod tidy) test: update go mod before testing(go mod tidy) Feb 6, 2023
@vmihailenco
Copy link
Collaborator

Sometimes updating the dependencies will break the build which can be annoying if all you want is to run the tests...

@monkey92t
Copy link
Collaborator Author

Sometimes updating the dependencies will break the build which can be annoying if all you want is to run the tests...

#2420 #2421

@monkey92t
Copy link
Collaborator Author

@vmihailenco We need to update go.sum in order to run the tests.

@vmihailenco
Copy link
Collaborator

@monkey92t alright, I did not realize that. Could you change make go_mod_tidy to not run go get -u and make a separate command like make update_deps that updates dependencies? Then we can merge this.

Signed-off-by: monkey92t <golang@88.com>
@monkey92t
Copy link
Collaborator Author

It seems that we only need to run go mod tidy when make test.

@vmihailenco
Copy link
Collaborator

Thanks 👍

@monkey92t monkey92t merged commit 1cb89d7 into redis:master Feb 8, 2023
@monkey92t monkey92t deleted the mod_tidy branch February 11, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants