fix: group lag can be null #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a new field in redis7, so we don't need to port to v8. |
vmihailenco
reviewed
Feb 18, 2023
| @@ -2057,7 +2057,7 @@ func (cmd *XInfoGroupsCmd) readReply(rd *proto.Reader) error { | |||
| } | |||
| case "lag": | |||
| group.Lag, err = rd.ReadInt() | |||
| if err != nil { | |||
| if err != nil && err != Nil { | |||
There was a problem hiding this comment.
Having a comment here would help next time someone changes this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes 3+ hours of me trying to understand why things don't work
see https://github.com/redis/redis/blob/383d902ce68131cf40d6122ce09e305e672e8555/src/t_stream.c#L1456
change the behavior so that if lag is null, the group lag will be set to 0 instead of returning an error