Bloom support #2649
Bloom support #2649
Conversation
…or all data structures
|
You probably want to use |
|
The tests are not passing in CI because the code needs Redis Stack 7.2 RC3 or above. @chayim is working on a way to automate tests with a Redis Stack option. |
| BFReserve(ctx context.Context, key string, errorRate float64, capacity int64) *StatusCmd | ||
| BFReserveExpansion(ctx context.Context, key string, errorRate float64, capacity, expansion int64) *StatusCmd | ||
| BFReserveNonScaling(ctx context.Context, key string, errorRate float64, capacity int64) *StatusCmd | ||
| BFReserveArgs(ctx context.Context, key string, options *BFReserveOptions) *StatusCmd |
There was a problem hiding this comment.
I know that at this point the Args suffix looks like some kind of convention, but it never meant to be so and we don't really enforce it. So feel free to come with a better name :)
BFReserveExt or BFReserveOptions or BFReserveWithOptions might be it, but I don't feel strongly about it.
| "github.com/redis/go-redis/v9/internal/proto" | ||
| ) | ||
|
|
||
| type probabilisticCmdable interface { |
|
I'm closing this, since the commits went in another pr that's already merged. Thanks @ofekshenawa for working on it. |
part of #2068