Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bloom support #2673

Merged
merged 22 commits into from
Aug 15, 2023
Merged

bloom support #2673

merged 22 commits into from
Aug 15, 2023

Conversation

ofekshenawa
Copy link
Collaborator

  • bloom - initial import
  • Adds test for Bloom commands
  • Finishes bloom and cuckoo filters
  • Bloom, Cuckoo and CMS finished
  • Adds cms commands to interface
  • Adds TopK
  • Update for latest resp3 changes. Use a custom INFO response objects for all data structures
  • Adds tidigest commands (tdigest.merge missing)
  • Cleanup
  • More cleanups
  • Adds TDigestMerge
  • Applies fixes after review
  • Specifies number sizes
  • Missed file in commit
  • Improves API for BFInfo with args
  • Add SCANDUMP and LOADCHUNK for bf and cf
  • Add SCANDUMP and LOADCHUNK for bf and cf (Add SCANDUMP and LOADCHUNK for bf and cf #2668)

@chayim
Copy link
Contributor

chayim commented Aug 14, 2023

Update the README as discussed please

@chayim chayim self-requested a review August 14, 2023 14:36
@chayim chayim added the feature label Aug 14, 2023
@ofekshenawa ofekshenawa merged commit 558581e into master Aug 15, 2023
7 checks passed
@peczenyj
Copy link
Contributor

peczenyj commented Sep 8, 2023

Hello

because the probabilistic methods are defined in a private interface, included on the Universal client interface, we did not see the new methods in the documentation.

it may be a minor issue, but it is a little bit annoying— I had to use an IDE to find the cuckoo and bloomd methods.

is it possible include in another way? Perhaps keep the interfaces public?

https://pkg.go.dev/github.com/go-redis/redis/v9#UniversalClient

there is a link to

https://pkg.go.dev/github.com/go-redis/redis/v9#Cmdable

thanks

@ofekshenawa ofekshenawa deleted the bloom-support branch June 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants