Updated package version #3134
Merged
Updated package version #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofekshenawa
reviewed
Sep 26, 2024
ofekshenawa
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Please note that the version needs to be updated in additional places. Make sure to check all relevant files and documentation where the version is referenced to ensure consistency.
f.e https://github.com/redis/go-redis/pull/2917/files
|
@ofekshenawa But if we update it in submodules they will point to a version that doesn't exists yet right? My IDE is complaining when I'm doing so |
EXPEbdodla
pushed a commit
to EXPEbdodla/go-redis
that referenced
this pull request
Nov 15, 2024
* Updated package version * Changed version format according to specification * Updated submodule versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated package version to represent current version