Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for %d, %i and %f #12

Closed
wants to merge 2 commits into from
Closed

Conversation

nicolasff
Copy link
Contributor

Hello,

These two commits add support for %d, %i, and %f in redis commands.

Nicolas

@pietern
Copy link
Contributor

pietern commented Dec 1, 2010

Thanks for the patches. I think the one for %d can be applied, with the reservation that it would be better to immediately include padding and the other features you would expect for a printf-style. I think the %f one should not have a fixed precision, this is not something users will expect. Maybe it's better to scan the characters until a valid full printf-style argument is found that is not handled by Hiredis itself and pass the entire thing to the native printf / sdscatprintf function. This would give us everything printf can do in one go. What do you think?

@pietern
Copy link
Contributor

pietern commented Dec 2, 2010

We've discussed this, but for historical reasons: full printf support is introduced in antirez/hiredis@7684d55

@ghost ghost mentioned this pull request Oct 3, 2013
@fanbojie fanbojie mentioned this pull request Sep 14, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants