(Docs)fix wrong commands of enabling SSL/TLS support #1282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SSL/TLS support part, the current readme says to run
make USE_SSL=1
to build and install files related to hiredis_ssl. However, after running it, the system does not install thelibhiredis_ssl
correctly.This is due to the option here in
CMakeLists.txt
is set to OFF as default butmake USE_SSL=1
does not enable it.This is the result of just running
make USE_SSL=1
andsudo make install
This is the result of running
cmake . -DENABLE_SSL=ON
before the commands above.So it's obvious to see that files of
libhiredis_ssl.so
,hiredis_ssl.h
and so on are left out and not installed correctly as expected. Thus I add the commands in theREADME.md
to fix the problem since it's really hard to detect.