make install should install dict.h system-wide #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about instead trying to make the hash table lib completely opaque to hiredis users? |
|
Yes, this is indeed a problem. I'd rather fix async.h to contain a forward declaration though. Adding this header system-wide has no real value. Even more so, I'm planning on making making dict.c all-static, so the entire c file can be included (because it is only used in isolation). |
|
I've patched this on master, could you let me know this works out for you? |
|
It works, thanks. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async.h includes dict.h, so dict.h needs to be installed system-wide too.
This fixes compilation of example-libev.c when it is modified to use system-wide installed include files.