refactor: use WeakMap to avoid attaching properties

redis · Mar 14, 2022 · 7b98355 · 7b98355
1 parent f293b97
commit 7b98355
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/cluster/index.ts b/lib/cluster/index.ts
@@ -40,6 +40,8 @@ import Deque = require("denque");
 
 const debug = Debug("cluster");
 
+const REJECT_OVERWRITTEN_COMMANDS = new WeakSet<Command>();
+
 type ClusterStatus =
   | "end"
   | "close"
@@ -477,11 +479,9 @@ class Cluster extends Commander {
     let targetSlot = node ? node.slot : command.getSlot();
     const ttl = {};
     const _this = this;
-    // @ts-expect-error
-    if (!node && !command.__is_reject_overwritten) {
-      // TODO WeakMap
-      // @ts-expect-error
-      command.__is_reject_overwritten = true;
+    if (!node && !REJECT_OVERWRITTEN_COMMANDS.has(command)) {
+      REJECT_OVERWRITTEN_COMMANDS.add(command);
+
       const reject = command.reject;
       command.reject = function (err) {
         const partialTry = tryConnection.bind(null, true);