-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: improve proto checking for hgetall [skip ci] (#1418)
* fix: improve proto checking for hgetall As mentioned in #1417 * Address feedbacks
- Loading branch information
Showing
2 changed files
with
29 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,37 @@ | ||
import Redis from "../../lib/redis"; | ||
import { expect } from "chai"; | ||
|
||
const CUSTOM_PROPERTY = "_myCustomProperty"; | ||
|
||
describe("hgetall", function () { | ||
it("should handle __proto__", async function () { | ||
beforeEach(function () { | ||
Object.defineProperty(Object.prototype, CUSTOM_PROPERTY, { | ||
value: false, | ||
configurable: true, | ||
enumerable: false, | ||
writable: false, | ||
}); | ||
}); | ||
|
||
afterEach(function () { | ||
delete (Object.prototype as any)[CUSTOM_PROPERTY]; | ||
}); | ||
|
||
it("should handle special field names", async function () { | ||
const redis = new Redis(); | ||
await redis.hset("test_key", "__proto__", "hello"); | ||
await redis.hmset( | ||
"test_key", | ||
"__proto__", | ||
"hello", | ||
CUSTOM_PROPERTY, | ||
"world" | ||
); | ||
const ret = await redis.hgetall("test_key"); | ||
expect(ret.__proto__).to.eql("hello"); | ||
expect(Object.keys(ret)).to.eql(["__proto__"]); | ||
expect(ret[CUSTOM_PROPERTY]).to.eql("world"); | ||
expect(Object.keys(ret).sort()).to.eql( | ||
["__proto__", CUSTOM_PROPERTY].sort() | ||
); | ||
expect(Object.getPrototypeOf(ret)).to.eql(Object.prototype); | ||
}); | ||
}); |