Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling disconnect(true) multiple times #1138

Closed
alexandre-abrioux opened this issue May 27, 2020 · 1 comment
Closed

calling disconnect(true) multiple times #1138

alexandre-abrioux opened this issue May 27, 2020 · 1 comment
Labels
released

Comments

@alexandre-abrioux
Copy link
Contributor

Hi!

I've noticed that calling the disconnect(true) sequentially multiple times actually cancels the re-connection process.

The issue resides in the disconnect method where the clearTimeout function is called regardless of whether or not the reconnect parameter is set to true:

public disconnect(reconnect = false) {
  ...
  if (this.reconnectTimeout) { // <-- here we should check if reconnect is also false
    clearTimeout(this.reconnectTimeout);
    ....
  }
  ...
}

I've made a fix that I will introduce in a new PR following the opening of this issue.

Thank you for your time!

PS: this issue might be related to #1007.
alexandre-abrioux added a commit to alexandre-abrioux/ioredis that referenced this issue May 27, 2020
@alexandre-abrioux
[reconnect] write test cases for issue redis#1138
6f5a0c1
alexandre-abrioux added a commit to alexandre-abrioux/ioredis that referenced this issue May 27, 2020
@alexandre-abrioux
[reconnect] fixes redis#1138
a373309
@alexandre-abrioux alexandre-abrioux mentioned this issue May 27, 2020
Merged
@luin luin closed this as completed in 6fad73b May 30, 2020
ioredis-robot pushed a commit that referenced this issue May 30, 2020
@semantic-release-bot
chore(release): 4.17.3 [skip ci]
11e5d81 
## [4.17.3](v4.17.2...v4.17.3) (2020-05-30)

### Bug Fixes

* race conditions in `Redis#disconnect()` can cancel reconnection unexpectedly ([6fad73b](6fad73b)), closes [#1138](#1138) [#1007](#1007)
@ioredis-robot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.17.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this issue Dec 5, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Jan 6, 2021
Closed
janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this issue Mar 1, 2024
@janus-dev87
chore(release): 4.17.3 [skip ci]
1bff472 
## [4.17.3](redis/ioredis@v4.17.2...v4.17.3) (2020-05-30)

### Bug Fixes

* race conditions in `Redis#disconnect()` can cancel reconnection unexpectedly ([6fad73b](redis/ioredis@6fad73b)), closes [#1138](redis/ioredis#1138) [#1007](redis/ioredis#1007)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@alexandre-abrioux @ioredis-robot