fix: support TypeScript interface as parameters of hmset and mset #1545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1536
There is a limit on the TypeScript side microsoft/TypeScript#15300 (comment) that you can't assign an interface to a record:
Given
hmset
andmset
already support ES6Map
, I think it's should be fine to loosen the typing here for convenience.It's possible that developers may pass invalid object values (e.g.
redis.hmset("user-hash", new WeakMap([[{ name: "Bob" }, "value"]]))
) but I think that's fine since the usage doesn't make sense and it will trigger an runtime error anyway.