Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Automatic-Module-Name to manifest #2201

Merged
merged 8 commits into from
Mar 18, 2021

Conversation

scholzi100
Copy link
Contributor

@scholzi100 scholzi100 commented Jun 4, 2020

This PR added the Automatic-Module-Name ("redis.clients.jedis") to the projects manifest.

This PR is related to Issue #2044.

Compile dependencies supporting Java Module System:

@wangminpku
Copy link

Dear scholzi100 ( @scholzi100) and Jedis team (@xetorthio), (@HeartSaVioR), (@sazzad16 )
We are working on automatically identifying and clustering the related pull requests for code review. We have found that PR#1909 might be related to this one, because both of them modified pom.xml in the same section.
We would really appreciate it if you could help us to validate if the information from PR#1909 is helpful when you review the current PR.
Thank you very much for your time!

@scholzi100
Copy link
Contributor Author

@wangminpku PR#1909 does not seam to be related to this PR.

@sazzad16 sazzad16 added this to the 3.6.0 milestone Jan 28, 2021
@sazzad16 sazzad16 removed the request for review from gkorland January 28, 2021 13:34
@gkorland
Copy link
Contributor

gkorland commented Feb 7, 2021

@scholzi100 is there a way to test it, to verify the build process?

@scholzi100
Copy link
Contributor Author

@gkorland To verify the module is working. I think a seperate module using java 11 with module-info would be required.

@gkorland gkorland requested a review from sazzad16 March 9, 2021 10:21
@sazzad16
Copy link
Collaborator

sazzad16 commented Mar 9, 2021

@scholzi100 Would you be able to add the module name redis.clients.jedis as property and use that property in Automatic-Module-Name tag? Thanks!

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

property tags don't match

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@sazzad16 sazzad16 merged commit b023d86 into redis:master Mar 18, 2021
@sazzad16 sazzad16 mentioned this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants