Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SYNC command #2499

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Remove SYNC command #2499

merged 1 commit into from
Apr 11, 2021

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Apr 6, 2021

Resolves #1736

@sazzad16 sazzad16 added this to the 4.0.0 milestone Apr 6, 2021
@sazzad16 sazzad16 requested a review from gkorland April 6, 2021 11:26
@gkorland
Copy link
Contributor

gkorland commented Apr 6, 2021

@sazzad16 do we know why was this command added at the first place?

@sazzad16
Copy link
Collaborator Author

sazzad16 commented Apr 6, 2021

@gkorland It was added in a8ffacd on Sep 14, 2010!
The commit message states

Added bunch of missing commands ...

It seems it was added without much thought when some missing commands were being implemented in Jedis. May be there wasn't a clear idea about which commands to include and which ones to omit.

@sazzad16 sazzad16 merged commit 9c66c69 into redis:master Apr 11, 2021
@sazzad16 sazzad16 deleted the remove-sync-command branch April 11, 2021 12:31
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Apr 11, 2021
sazzad16 added a commit that referenced this pull request Apr 14, 2021
@sazzad16
Copy link
Collaborator Author

Backported via #2507

@chayim chayim mentioned this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support of SYNC
3 participants