Support parsing '-nan' #3329
Merged
Support parsing '-nan' #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to usages of `sprintf(str, "%.15g", d);` when d is NaN. From @LiorKogan: "We should treat `-nan` as `nan`". References: - RedisGraph/RedisGraph#2930
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #3329 +/- ##
============================================
- Coverage 67.00% 67.00% -0.01%
+ Complexity 4660 4657 -3
============================================
Files 263 263
Lines 15088 15088
Branches 951 951
============================================
- Hits 10110 10109 -1
+ Misses 4571 4570 -1
- Partials 407 409 +2
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
banker
pushed a commit
to banker/jedis
that referenced
this pull request
Mar 28, 2023
Due to usages of `sprintf(str, "%.15g", d);` when d is NaN. From @LiorKogan: "We should treat `-nan` as `nan`". References: - RedisGraph/RedisGraph#2930
This was referenced Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to usages of
sprintf(str, "%.15g", d);when d is NaN.From @LiorKogan: "We should treat
-nanasnan".References: