Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use Pub/Sub codes #3389

Merged
merged 3 commits into from
May 3, 2023
Merged

Re-use Pub/Sub codes #3389

merged 3 commits into from
May 3, 2023

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented May 3, 2023

No description provided.

@sazzad16 sazzad16 added the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label May 3, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 76.19% and project coverage change: -0.06 ⚠️

Comparison is base (024e066) 67.24% compared to head (a4eb369) 67.18%.

❗ Current head a4eb369 differs from pull request most recent head f484582. Consider uploading reports for the commit f484582 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##                5.0    #3389      +/-   ##
============================================
- Coverage     67.24%   67.18%   -0.06%     
+ Complexity     4767     4748      -19     
============================================
  Files           270      271       +1     
  Lines         15459    15350     -109     
  Branches       1004      992      -12     
============================================
- Hits          10395    10313      -82     
+ Misses         4625     4606      -19     
+ Partials        439      431       -8     
Impacted Files Coverage Δ
...main/java/redis/clients/jedis/JedisPubSubBase.java 75.24% <75.24%> (ø)
...in/java/redis/clients/jedis/BinaryJedisPubSub.java 100.00% <100.00%> (+17.02%) ⬆️
src/main/java/redis/clients/jedis/JedisPubSub.java 100.00% <100.00%> (+32.50%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 merged commit 8ee0d30 into redis:5.0 May 3, 2023
@sazzad16 sazzad16 deleted the pubsub-mod branch May 3, 2023 10:32
@sazzad16 sazzad16 added maintenance and removed breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. labels Jun 13, 2023
@sazzad16 sazzad16 added this to the 5.0.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants