Return List instead of Set in ZDIFF, ZINTER, ZUNION #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- zdiff, zinter, zunion methods now return List instead of Set - ...store methods are renamed to ...Store - ...card methods are renamed to ...Card
sazzad16
added
breakingchange
sazzad16
force-pushed
the
z-commands-order
branch
from
7aed3a0 to
68d8bbe
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #3431 +/- ##
============================================
- Coverage 68.07% 67.95% -0.12%
+ Complexity 4543 4537 -6
============================================
Files 275 275
Lines 14597 14593 -4
Branches 978 977 -1
============================================
- Hits 9937 9917 -20
- Misses 4248 4265 +17
+ Partials 412 411 -1
☔ View full report in Codecov by Sentry. |
Comment on lines
+21
to
+31
| - `zdiff(String... keys)` method now returns `List<String>` (instead of `Set<String>`). | ||
| - `zdiff(byte[]... keys)` method now returns `List<byte[]>` (instead of `Set<byte[]>`). | ||
| - Both `zdiffWithScores(String... keys)` and `zdiffWithScores(byte[]... keys)` methods now return `List<Tuple>` (instead of `Set<Tuple>`). | ||
|
|
||
| - `zinter(ZParams params, String... keys)` method now returns `List<String>` (instead of `Set<String>`). | ||
| - `zinter(ZParams params, byte[]... keys)` method now returns `List<byte[]>` (instead of `Set<byte[]>`). | ||
| - Both `zinterWithScores(ZParams params, String... keys)` and `zinterWithScores(ZParams params, byte[]... keys)` methods now return `List<Tuple>` (instead of `Set<Tuple>`). | ||
|
|
||
| - `zunion(ZParams params, String... keys)` method now returns `List<String>` (instead of `Set<String>`). | ||
| - `zunion(ZParams params, byte[]... keys)` method now returns `List<byte[]>` (instead of `Set<byte[]>`). | ||
| - Both `zunionWithScores(ZParams params, String... keys)` and `zunionWithScores(ZParams params, byte[]... keys)` methods now return `List<Tuple>` (instead of `Set<Tuple>`). |
Conflicts: src/main/java/redis/clients/jedis/MultiNodePipelineBase.java src/main/java/redis/clients/jedis/Pipeline.java src/test/java/redis/clients/jedis/commands/jedis/SortedSetCommandsTest.java src/test/java/redis/clients/jedis/commands/unified/SortedSetCommandsTestBase.java
sazzad16
changed the title
yangbodong22011
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3083