Client setinfo ignore all exception (#3449) #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains the following changes: 1. Check the character legality of clientName in advance through `validateClientInfo`, so that character exceptions are ignored in `initializeFromClientConfig`. 2. Move the `select` command out of the fire-and-forget message (we care about its return value). 3. For the test of RedisCredentials, we gave it "invalidPass" for the first time to make it fail the verification instead of skipping the verification.
chayim
reviewed
Jun 5, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## 4.x #3458 +/- ##
============================================
+ Coverage 67.24% 67.25% +0.01%
- Complexity 4734 4738 +4
============================================
Files 269 269
Lines 15308 15304 -4
Branches 966 962 -4
============================================
- Hits 10294 10293 -1
+ Misses 4591 4590 -1
+ Partials 423 421 -2
☔ View full report in Codecov by Sentry. |
yangbodong22011
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
validateClientInfo, so that character exceptions are ignored ininitializeFromClientConfig.selectcommand out of the fire-and-forget message (we care about its return value).