Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Java code snippets for count min sketch #3644

Merged
merged 5 commits into from
Jan 13, 2024
Merged

Create Java code snippets for count min sketch #3644

merged 5 commits into from
Jan 13, 2024

Conversation

Harsh4902
Copy link
Contributor

@dwdougherty
Copy link
Contributor

While I didn't attempt to run the example, I did build the docs using this PR and it built and displays correctly.

@Harsh4902
Copy link
Contributor Author

While I didn't attempt to run the example, I did build the docs using this PR and it built and displays correctly.

Okay, thank you.

@Harsh4902
Copy link
Contributor Author

@sazzad16 please review this PR

sazzad16
sazzad16 suggested changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Harsh4902 Format it to be more readable and look nicer. Thanks

@sazzad16 sazzad16 linked an issue Dec 29, 2023 that may be closed by this pull request
Create Java code snippets for count min sketch #3633
Closed
@dwdougherty
Copy link
Contributor

@sazzad16 Can you be more specific? This code example seems to be consistent with the others.

@sazzad16
Copy link
Contributor

sazzad16 commented Jan 2, 2024

@dwdougherty Please review now.

@Harsh4902
Copy link
Contributor Author

@sazzad16 Is there any requirement of formatting now? If yes, please suggest where I can improve.

@sazzad16
Copy link
Contributor

sazzad16 commented Jan 2, 2024

Is there any requirement of formatting now? If yes, please suggest where I can improve.

@Harsh4902 Check my commits in this PR. I hope you would understand.

@Harsh4902
Copy link
Contributor Author

@sazzad16 Aha, got your point. Now I will definitely take care of it. Thank you.

@dwdougherty
Copy link
Contributor

@sazzad16 This PR builds correctly and it's good to go.

@sazzad16 sazzad16 merged commit da8e25c into redis:emb-examples Jan 13, 2024
1 check passed
@sazzad16 sazzad16 mentioned this pull request Jan 13, 2024
Closed
uglide added a commit that referenced this pull request Jun 18, 2024
@uglide @elena-kolevska
@bsbodden @sazzad16 @Harsh4902 @Ranjeet0611 @suraj11chauhan @dwdougherty
Merge doc tests into main branch to keep in-sync with the code (#3861)
f4fcc36 
* Fix search_quickstart example

* Add data_class step to SearchQuickstartExample

* Update examples with new bikes and align to new tutorial

* Fixes doctests for search tutorial

* Small fixes doctests

* Updates search tutorial doc examples to new format and data

* Fix formatting in doc tests

* Add Hashes and String Example (#3477)

* Add Hashes Example

* Fixes examples for hash tutorial

* Refactor Hash Tutorial to Java 8 (from 17)

* Change indentation to 4 spaces

* Add Strings Example

* Reformat samples to 2-space indentation

---------

Co-authored-by: Elena Kolevska <elena@kolevska.com>

* Add Geospatial data type example (#3487)

* Add Geospatial data type example

* Add missing REMOVE_END

* Added example Java code snippets for Streams (#3641)

* Java example code snippets for T-Digest and TopK (#3660)

* Created example for t digest

* Added example for topK

---------

Co-authored-by: Ranjeet Singh <ranjeetsingh@192.168.1.12>
Co-authored-by: Ranjeet Singh <ranjeetsingh@192.168.1.11>

* Create Java code snippets for sets #3626 (#3661)

* Create Java code snippets for sets #3626

* Apply suggestions from code review to add // STEP_END lines.

Co-authored-by: David Dougherty <david.dougherty@redis.com>

* format imports

---------

Co-authored-by: David Dougherty <david.dougherty@redis.com>
Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>

* Create Java code snippets for count min sketch (#3644)

* added code snippet for CMS in Java

* Update CMSExample.java

* format spaces

* use cmsIncrBy simple variant

* more format spaces

---------

Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>

* Added Java code snippets for Bloom #3630  (#3671)

* Added java example for bloom filter

* Removed space

* fix and format imports

* fix compile error

* format spaces

* Add del command and rename obj

* Add del command and fix format

* change to junit assert

* Update BloomFilterExample.java

* Add correct output comment

---------

Co-authored-by: Ranjeet Singh <ranjeetsingh@192.168.1.11>
Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
Co-authored-by: Ranjeet Singh <ranjeetsingh@192.168.1.7>

* Added java code snippet for hyperloglog (#3674)

* Added Java code snippet for HyperLogLog

* fix format and imports

* fix spaces

* change to junit assert

* Added correct output comment

* Update HyperLogLogExample.java

---------

Co-authored-by: Ranjeet Singh <ranjeetsingh@192.168.1.7>
Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>

* Added Java code snippets for cuckoo filters (#3679)

* Add CuckooFilterExample

* Add step start comment

* Update CuckooFilterExample.java

---------

Co-authored-by: Ranjeet Singh <ranjeetsingh@192.168.1.7>
Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>

* Create Java code snippet for lists #3625 (#3677)

* Added example Java code snippets for the List#3625

* format spaces

---------

Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>

* Create Java code snippet for sorted sets  (#3680)

* added an example for SortedSets in java

* Update SortedSetsExample.java

* made changes as per the review.

* Format spaces in SortedSetsExample.java

---------

Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>

* Added Java code snippet for bitmap  (#3687)

* Add bitmap example

* Change class name

* Add assert for res3 and res4

* Update BitMapsExample.java

* Format spaces in BitMapsExample.java

---------

Co-authored-by: Ranjeet Singh <ranjeetsingh@192.168.1.7>
Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>

---------

Co-authored-by: Elena Kolevska <elena@kolevska.com>
Co-authored-by: Brian Sam-Bodden <bsbodden@integrallis.com>
Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
Co-authored-by: Harshvardhan Parmar <harshparmar4902@gmail.com>
Co-authored-by: Ranjeet SIngh <32495484+Ranjeet0611@users.noreply.github.com>
Co-authored-by: Ranjeet Singh <ranjeetsingh@192.168.1.12>
Co-authored-by: Ranjeet Singh <ranjeetsingh@192.168.1.11>
Co-authored-by: Suraj <112368828+suraj11chauhan@users.noreply.github.com>
Co-authored-by: David Dougherty <david.dougherty@redis.com>
Co-authored-by: Ranjeet Singh <ranjeetsingh@192.168.1.7>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

@sazzad16 sazzad16 sazzad16 approved these changes

Assignees
No one assigned
Labels
docs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Java code snippets for count min sketch
3 participants
@Harsh4902 @dwdougherty @sazzad16