-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Redis Command retrieval for Redis Cluster Connections #1481
Labels
type: task
A general task
Milestone
Comments
Lettuce requires at least Redis 3.2.10 when using Geo Commands. 3.2.0 - 3.2.9 don't ship with |
mp911de
added a commit
that referenced
this issue
Jan 8, 2021
We now no longer query Redis Cluster nodes for their known commands to determine whether to call _RO variants of GEORADIUS and GEORADIUSBYMEMBER. Therefore, Lettuce requires a Redis server providing GEORADIUS_RO and GEORADIUSBYMEMBER_RO commands. So when using Geo commands, Lettuce requires Redis 3.2.10 as versions 3.2.0 to 3.2.9 do not support the _RO command variants.
mp911de
added a commit
that referenced
this issue
Jan 14, 2021
ggivo
added a commit
to ggivo/lettuce
that referenced
this issue
Oct 30, 2024
…lica" on READS... only if master & replica configured redis#1813 Divert pure read intentions of georadius and georadiusbymember commands (variants that do not use STORE/STOREDIST) to GEORADIUS_RO/GEORADIUSBYMEMBER_RO This will unify the behaviour between Cluster and Redis Standalone/Replica arrangements Relates to issues redis#1481 redis#2568 redis#2871 Closes redis#1813
tishun
pushed a commit
that referenced
this issue
Nov 5, 2024
…lica " on READS... (#3032) * OpsForGeo producing "READONLY You can't write against a read only replica" on READS... only if master & replica configured #1813 Divert pure read intentions of georadius and georadiusbymember commands (variants that do not use STORE/STOREDIST) to GEORADIUS_RO/GEORADIUSBYMEMBER_RO This will unify the behaviour between Cluster and Redis Standalone/Replica arrangements Relates to issues #1481 #2568 #2871 Closes #1813 * Fix tests * Remove unused methods * Fix tests and add tests withArgs
tishun
pushed a commit
that referenced
this issue
Dec 1, 2024
…lica " on READS... (#3032) * OpsForGeo producing "READONLY You can't write against a read only replica" on READS... only if master & replica configured #1813 Divert pure read intentions of georadius and georadiusbymember commands (variants that do not use STORE/STOREDIST) to GEORADIUS_RO/GEORADIUSBYMEMBER_RO This will unify the behaviour between Cluster and Redis Standalone/Replica arrangements Relates to issues #1481 #2568 #2871 Closes #1813 * Fix tests * Remove unused methods * Fix tests and add tests withArgs
thachlp
pushed a commit
to thachlp/lettuce
that referenced
this issue
Dec 31, 2024
…lica " on READS... (redis#3032) * OpsForGeo producing "READONLY You can't write against a read only replica" on READS... only if master & replica configured redis#1813 Divert pure read intentions of georadius and georadiusbymember commands (variants that do not use STORE/STOREDIST) to GEORADIUS_RO/GEORADIUSBYMEMBER_RO This will unify the behaviour between Cluster and Redis Standalone/Replica arrangements Relates to issues redis#1481 redis#2568 redis#2871 Closes redis#1813 * Fix tests * Remove unused methods * Fix tests and add tests withArgs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the introduction of Read-Only variants for Geo commands (e.g.
GEORADIUSBYMEMBER_RO
,GEORADIUS_RO
) we started obtaining command details upon connect when using Redis Cluster to ensure that read operations use read commands and utilize replicas.Since this functionality dates back to Redis 3.2, we should consider removing this step and assume that Read-Only commands are generally available and switch to these.
The text was updated successfully, but these errors were encountered: