Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception type for READONLY errors #1944

Closed
wants to merge 1 commit into from
Closed

Add exception type for READONLY errors #1944

wants to merge 1 commit into from

Conversation

anothertobi
Copy link
Contributor

Redis instances in read-only mode will reply with a READONLY error
message when a write is attempted. This change allows users to
specifically handle these errors.

Fixes #1943

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@anothertobi
Add exception type for READONLY errors
1ef8b40 
Redis instances in read-only mode will reply with a `READONLY` error
message when a write is attempted. This change allows users to
specifically handle these errors.

Fixes #1943
@mp911de mp911de added this to the 6.1.6 milestone Jan 3, 2022
@mp911de mp911de added the type: feature A new feature label Jan 4, 2022
@mp911de mp911de changed the title Add exception type for READONLY errors Add exception type for READONLY errors Jan 4, 2022
mp911de pushed a commit that referenced this pull request Jan 4, 2022
@anothertobi @mp911de
Add exception type for READONLY errors #1943
0b70fb4 
Redis instances in read-only mode will reply with a `READONLY` error
message when a write is attempted. This change allows users to
specifically handle these errors.

Original pull request: #1944.
mp911de added a commit that referenced this pull request Jan 4, 2022
@mp911de
Polishing #1943
b26d384 
Add author and since tags.

Original pull request: #1944.
mp911de pushed a commit that referenced this pull request Jan 4, 2022
@anothertobi @mp911de
Add exception type for READONLY errors #1943
6146aef 
Redis instances in read-only mode will reply with a `READONLY` error
message when a write is attempted. This change allows users to
specifically handle these errors.

Original pull request: #1944.
mp911de added a commit that referenced this pull request Jan 4, 2022
@mp911de
Polishing #1943
462264e 
Add author and since tags.

Original pull request: #1944.
@mp911de
Copy link
Collaborator

mp911de commented Jan 4, 2022

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.1.6
Development

Successfully merging this pull request may close these issues.

Add exception type for READONLY errors
2 participants
@anothertobi @mp911de