Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io.lettuce.core.RedisCommandExecutionException: NOAUTH Authentication required on CLIENT and READONLY command #3035

Merged
merged 1 commit into from
Oct 31, 2024
Merged

io.lettuce.core.RedisCommandExecutionException: NOAUTH Authentication required on CLIENT and READONLY command #3035

merged 1 commit into from
Oct 31, 2024
+85 −16

Conversation

ggivo
Copy link
Contributor

@ggivo ggivo commented Oct 30, 2024 •
edited
Loading

Using custom credentials provider can delay providing credentials. In this case applyPostHandshake and applyConnectionMetadata got executed before handshake and led to a NOAUTH error in the log for CLIENT command.
Closes #2996

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@ggivo
io.lettuce.core.RedisCommandExecutionException: NOAUTH Authentication…
54c23a6 
… required on CLIENT and READONLY command

Using custom credentials provider can delay providing of credentials. In this case applyPostHandshake and applyConnectionMetadata got executed before handshake and lead to NOAUTH error in the log for CLIENT command.
@ggivo ggivo marked this pull request as draft October 30, 2024 17:03
@ggivo ggivo linked an issue Oct 30, 2024 that may be closed by this pull request
io.lettuce.core.RedisCommandExecutionException: NOAUTH Authentication required on CLIENT and READONLY command #2996
Closed
@ggivo ggivo self-assigned this Oct 30, 2024
@ggivo ggivo marked this pull request as ready for review October 31, 2024 05:19
tishun
tishun approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this!

@tishun tishun merged commit 7f455ec into redis:main Oct 31, 2024
5 checks passed
@ggivo ggivo deleted the 2996-noauth-on-delayed-credentials branch November 4, 2024 14:06
@mp911de mp911de mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tishun tishun tishun approved these changes

Assignees

@ggivo ggivo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

io.lettuce.core.RedisCommandExecutionException: NOAUTH Authentication required on CLIENT and READONLY command
2 participants
@ggivo @tishun